search

Andrey2470T / trainpack

A collection of all train mods based on advtrains which made by various people.
Other
2 stars 0 forks source link

Modularity/individual maintenance & contribution #2

Open Montandalar opened 2 years ago

Montandalar commented 2 years ago

I noticed you have been improving some of MBB's mods. I have also done this to some of his mods as published on my own forks. I am not sure if you have used MBB's stuff directly or any of my forks?

I really want changes to be any of the mods in this pack to available as individual mods, because you shouldn't have to install the whole trainpack just to get a better version of something that's included with it. I will gladly merge any of your changes into my own repositories if you do not want to keep individual repositories for each of these mods.

I really want to suggest git submodules, but I realise you have a modpack here. I wrote up this whole rant about nested modpacks, but to be pragmatic, I don't think they're going to happen. I think the best thing we could do it un-modpackify the trainpack and make it just a collection of mods. That way dependencies can be better managed, like in Pandorabox Mods or Forks Modpack. I'd be happy to help further explain and guide on why I think submodules are better than your current approach.

wsor4035 commented 2 years ago

agreed that using submodules for this is a better approach

Andrey2470T commented 2 years ago

Oh, I didn't know you also manage the own modified versions of those mods. I know their author like abandoned them long ago and since they are actually currently broken and the API that they use is outdated, I was obliged to make the fixes.

I suppose the approach with using git submodules inside the nested mods is more rational. And yes, the most of my changes are similar to your ones, however, I also fixed the eye offsets and attachment offsets of many trains since an attached player with them looked like particularly out-of-bounds of the trains models. I think I will open PRs with those changes a bit later, then clone your mods inside my modpack when they get merged and will keep them as "mirrors" of your repos. So, in a case of coming new commits to your repos, I will pull them and then push to keep them up-to-date.

Montandalar commented 2 years ago

The problem I see around MBB's mods is copyright since most of them aren't licensed. Most other train mods have an active maintainer, so not really any issues around them. So I would suggest making a GitHub Organization to centrally manage some of the other mods, but I'm a bit uneasy about MBB's stuff.

I have emailed him to ask him to come out and tell people they are now licensed under something like CC-BY-SA, but no response, probably went to spam. He doesn't check the forums any more either. Thoughts?

Montandalar commented 2 years ago

MBB (now mbruchert) has recently come back and merged a lot of PRs, so possibly a lot of mods can be retargeted at his repos, although I don't know if he is going to continue to be active in merging PRs.

Montandalar commented 2 years ago

I now have an update on MBB's mods: They are fine to use under CC-BY-SA 3.0. Full details over on the forums. I now think a GitHub or NotABug organisation should take over the mods because he's not that interested in Minetest any more.