AndreyAttr / Evo

Evo repo
MIT License
0 stars 1 forks source link

Cleaning code for molecule-viewer-component/webpack.common.config #25

Open AndreyAttr opened 7 years ago

AndreyAttr commented 7 years ago

Avoid:

Need to edit: project.json to exclude: bundle-loader includes-loader

AndreyAttr commented 7 years ago

Also need to clean webpack.common.config file and remove useless comments

AndreyAttr commented 7 years ago

And also - we do not need file-loader for

test: /.(pdb|xyz|mol|sdf)$/,

in [webpack.common.config] Because in the molecule-viewer-component.ts @AndreyAttr used raw-loader to download data to memory

AndreyAttr commented 7 years ago

Also we can try to configure all the information into webpack.common.config.ts See sample here:

https://medium.com/@deeepakampolu/using-loaders-with-webpack-f724e8d6469b see section Inline configuration there

//require(‘imports?angular=angular&$=jquery&moment=moment!angular-daterangepicker/js/angular-daterangepicker’);

require(exports?Backbone!imports?_=lodash&$=jquery!backbone.js);

{
  module: {
    loaders: [
      { test: /underscore/, loader: 'exports?_' }
      { test: /backbone/, 
        loader: 'exports?Backbone!imports?underscore=underscore&jquery=jquery' 
      }
    ]
  }
}