ObjectHelper.deepCopy()

[AndreyAttr]

• [x] ObjectHelper should have deepTreeCopy() to use it to simple resolve this ugly solution:

  const gene:Gene = {
          name: this.gene.name,
          id: this.gene.id,
          sites: this.gene.sites,
          isMutated: this.gene.isMutated,
          //mutationSites: formModel.formGroups,      //TODO: Bad - need deep copy
          mutationSites: mutatedSites,                //Done
          description: formModel.description as string
      };

  it should proccess nested items & arrays & nested arrays correctly by using already existed deepCopy() & deepCopyArray() methods. Update: it would be nice have 3 overloads with the same name deepCopy() to process simple flat items/arrays of items/tree items properly.

[AndreyAttr]

Overloads doesn't work:

//Workaround: commented, because overload doesn't work with generic types. It works properly with non-generic types
//Workaround: but it sees only first version of overload for generics and doesn't see others.

Logic for this task has finished, but we have some parts of application which must be refactored to apply these new changes, as descriebed into https://github.com/AndreyAttr/Evo/issues/65. Actually, untill we merge these changes to angular branch it's a blocker task

[tapy-lappy]

I found not obvious problems with deepCopy(). Problems in following:

• [x] it losts the type of copied nested property(sub-item) - absent type Site onto second picture
• [x] it doesn't copy computable properties - see property name of Site item on second picture

[AndreyAttr]

No, that workaround is unappropriate. It will cause many problems in future. I have to reject. Will try to find other solution

[AndreyAttr]

This issue is a blocker for #65

[AndreyAttr]

So pull request #90 about workaround may be rejected - this is correct aproach which fixed @tapy-lappy 's comment https://github.com/AndreyAttr/Evo/issues/76#issuecomment-321009387