Andriamanitra / coctus

Command line tool for playing Clash of Code locally
MIT License
4 stars 2 forks source link

Rework solution api #71

Closed ellnix closed 1 month ago

ellnix commented 1 month ago

Regarding App

I suggest

This would then separate the responsibility between calling the commands and the helper functions which we could use in tests. It would also prepare for #61 by allowing configuration to be stored in App and be used by users of the lib.

ellnix commented 1 month ago

I don't know if the unable_to_run and get_result functions are particularly useful as they can only ever be called from one place but it's whatever.

The purpose was more to make each function easier to skim + group and document what those lines of code were doing.

The behavior change in --timeout needs fixing though.

Done, sorry about that.