search

Andrii-Detix / Sliding_Puzzle_Project

0 stars 0 forks source link

Code review #7

Open tshemsedinov opened 6 months ago

tshemsedinov commented 6 months ago
  1. Use collections instead of switch/case https://github.com/Andrii-Detix/Sliding_Puzzle_Project/blob/b294ec0ae0cb72e3d566c502f1ebea7a45ff95c5/Sliding%20Puzzle%20Project/Logic.cs#L7-L37
  2. Magic numbers detected: https://github.com/Andrii-Detix/Sliding_Puzzle_Project/blob/b294ec0ae0cb72e3d566c502f1ebea7a45ff95c5/Sliding%20Puzzle%20Project/Logic.cs#L83
  3. Try to rewrite twice shorter https://github.com/Andrii-Detix/Sliding_Puzzle_Project/blob/b294ec0ae0cb72e3d566c502f1ebea7a45ff95c5/Sliding%20Puzzle%20Project/Logic.cs#L95-L114
tshemsedinov commented 6 months ago

You need to view lecture about antipatterns again