Ideas: Favourites improvement, GPS drift and show favourites on map.

Android1500 / GpsSetter

Xposed module which will set location where you want without effect mock location.

327 stars 48 forks source link

Ideas: Favourites improvement, GPS drift and show favourites on map. #15

Open Rognils opened 1 year ago

Rognils commented 1 year ago

FIRST of all! You are awesome for creating this. Thank you for taking your precious time to create this for all of us. Keep it up.

The favourite list would be nice to be able to RENAME, EDIT or SORT by alphabet.
GPS drift. Current random position option jumps around alot, is it possible to make it drift in one random direction with minimal movement? So it looks more natural?
Show favourites on map. Is it possible to have the bookmarked favourites show up on the map? Maybe make them clickable in order to choose the one you want.

I understand this is extra stuff not necessary since the app is working awesome as it is :). Thank you again.

Android1500 commented 1 year ago

I will add these features in upcomming release

simonbuehler commented 1 year ago

great advancements!

yes , the jumping should be avoided as up to 25 meters every 200ms is not natural, this would trigger red flags in pogo

https://github.com/Android1500/GpsSetter/blob/6373c6f997a31158b80752ecf356e43927866449/app/src/main/java/com/android1500/gpssetter/xposed/XposedHook.kt#L217

rather

keep a position value of the current set "real location"
keep a movement direction value
generate a random step size between 0 and ~ 2m
Calculate new direction by changing current movement direction my small random amount
when distance of new randomized position is getting near the accuracy max make the direction head more to the center
set new calculated "fuzzy" position but keep "real location"

this way the fuzzy position should oscillate more naturally around the set position

simonbuehler commented 1 year ago

as a sidenote when a future version offers a joystick like control, a direction/heading and speed values would be needed

Rognils commented 1 year ago

SimonBuehler, you summed it up exactly the way I couldn't describe with words. Thanks! Make it more naturally.

Android1500 commented 1 year ago

great advancements!

yes , the jumping should be avoided as up to 25 meters every 200ms is not natural, this would trigger red flags in pogo

https://github.com/Android1500/GpsSetter/blob/6373c6f997a31158b80752ecf356e43927866449/app/src/main/java/com/android1500/gpssetter/xposed/XposedHook.kt#L217

rather

keep a position value of the current set "real location"

keep a movement direction value

generate a random step size between 0 and ~ 2m

Calculate new direction by changing current movement direction my small random amount

when distance of new randomized position is getting near the accuracy max make the direction head more to the center

set new calculated "fuzzy" position but keep "real location"

this way the fuzzy position should oscillate more naturally around the set position

Thanks for your suggestion can you push a pr with implement of your suggestion.

RevealedSoulEven commented 1 year ago

Also please consider adding speed hook to set gps speed like 70kmph speed for gps