search

AndroidDeveloperLB / LollipopContactsRecyclerViewFastScroller

A sample of how to mimic the way that the contacts app handles a Fast-Scroller for a RecyclerView
Apache License 2.0
540 stars 95 forks source link

If text to be shown in bubble is empty, hide the bubble #19

Closed akgoswam closed 6 years ago

akgoswam commented 6 years ago

It looks out of place that we simply show the bubble without text when text to show is empty. With this change, the bubble will be hidden using methods already provided.

AndroidDeveloperLB commented 6 years ago

You've tested it well, right?

akgoswam commented 6 years ago

Yes, we tested it out. The main issue we had was the following: we have a fab button in the bottom right. To accomodate that, we also had the last recyclerview position to be empty. When scrolled to the bottom, the text is empty, which only shows the bubble. That scenario was tested out. And also tested out empty text in between as well. Worked fine.

AndroidDeveloperLB commented 6 years ago

Well I suggest that when the user drags the scroller, you should hide the FAB, because it doesn't make sense to be able to press it while scrolling.

akgoswam commented 6 years ago

Its not the FAB that's the blocker, its the empty holder at the end of the recyclerview. That always will have empty text.

AndroidDeveloperLB commented 6 years ago

Why did you put empty holder? Why not add margin to the last item?

That's what I did on my apps here and here

I wonder what's the more common solution for this.