search

AndroidDeveloperLB / MaterialPreferenceLibrary

Allows to have an ActionBar on PreferenceActivity
Apache License 2.0
406 stars 69 forks source link

Custom ripple xml for android 6 #21

Closed jemshit closed 8 years ago

jemshit commented 8 years ago

Click event to center of list item still occurs sometimes even user clicks to corner of item. This removes double ripple effect when that occurs. Tested on android 4.1.2 , 4.4 , 5.0 , 6.0

AndroidDeveloperLB commented 8 years ago

You mean you fixed this issue: https://github.com/AndroidDeveloperLB/MaterialPreferenceLibrary/issues/19 ? I've tested it, and it shows a ripple in the center. I don't understand in which cases. I'm not sure if I prefer it with this bug or the other one. :(

jemshit commented 8 years ago

Yes, but there is still that weird click event even ripple effect looks correct. Try clicking to corner of first preference item on sample.

jemshit commented 8 years ago

And this doesn't add ripple for 2.x

AndroidDeveloperLB commented 8 years ago

What is the "weird click event" ? If it changes the behavior and not just how it looks, please tell me.

About 2.x , I didn't mean it does. I was hoping you'd know how to make it look at least like on ICS

On Mon, Feb 22, 2016 at 3:11 PM, Jemshit Iskenderov < notifications@github.com> wrote:

And this doesn't add ripple for 2.x

— Reply to this email directly or view it on GitHub https://github.com/AndroidDeveloperLB/MaterialPreferenceLibrary/pull/21#issuecomment-187165936 .

jemshit commented 8 years ago

Old sample demo video: http://sendvid.com/seggqpof New demo: http://sendvid.com/08lju6xz

AndroidDeveloperLB commented 8 years ago

yes, this is what I saw. It's better than before, but it's not quite a fix, as it can show middle ripple on some cases. :(

On Mon, Feb 22, 2016 at 4:55 PM, Jemshit Iskenderov < notifications@github.com> wrote:

Old sample demo video: http://sendvid.com/seggqpof New demo: http://sendvid.com/08lju6xz

— Reply to this email directly or view it on GitHub https://github.com/AndroidDeveloperLB/MaterialPreferenceLibrary/pull/21#issuecomment-187217595 .

AndroidDeveloperLB commented 8 years ago

Question: why for "mpl__custom_ripple_effect_background.xml" inside "drawable", you made all states show transparent color, instead of just a single item that show transparent (first one) ?

AndroidDeveloperLB commented 8 years ago

anyway, fixed this issue on version 7.