search

AndroidDumps / dumpyara

Generate a dump from an archive or image(s)
149 stars 116 forks source link

setup.sh: Switch from PyCrypto to PyCryptodome #50

Closed someone5678 closed 1 year ago

someone5678 commented 1 year ago

Ref: https://www.pycrypto.org https://www.pycryptodome.org

someone5678 commented 1 year ago

Are there any problem with PyCryptodome? @OneNormalUsername

OneNormalUsername commented 1 year ago

Hi @someone5678 , sorry for the delay. I'm actually unsure why pycrypto is a requirement in this repo. @deadman96385 @akhilnarang can you please help?

akhilnarang commented 1 year ago

Hi @someone5678 , sorry for the delay. I'm actually unsure why pycrypto is a requirement in this repo. @deadman96385 @akhilnarang can you please help?

I'm not sure either - could you try running some dumps without it maybe?

deadman96385 commented 1 year ago

I believe at one point it was used by kdz or one of the other proprietary formats. But not sure if it still is used.

someone5678 commented 1 year ago

@OneNormalUsername So... Should I just remove pycrypto from deps(Force push to change commit instead of replacing pycryptodome) or...? It's been months after this pr so...

OneNormalUsername commented 1 year ago

@someone5678 sorry, I meant to merge this earlier, I forgot to do it after @SebaUbuntu told me it should be fine

Ideally, we should investigate all of our dependencies and tools to ensure they stay up to date, but I don't have the time (nor the motivation) for that

akhilnarang commented 1 year ago

@someone5678 sorry, I meant to merge this earlier, I forgot to do it after @SebaUbuntu told me it should be fine

Ideally, we should investigate all of our dependencies and tools to ensure they stay up to date, but I don't have the time (nor the motivation) for that

Could setup dependabot and hope for minimal breakage