search

AndroidModLoader / JPatch

A little (yet) patch-mod that does a good thing!
MIT License
81 stars 4 forks source link

FixIsCharDead0HP breaks scripts #14

Open KoremuMekuro opened 1 year ago

KoremuMekuro commented 1 year ago

If this feature is enabled, then after loading save with this feature at least home_brains become broken(not working) and I assume that a lot of other regular scripts and mission scripts are become broken too, cuz alot of scripts uses this opcode. Also there may be cleo scripts that make use of this opcode, so I'm assume that they are may become broken(not working) too after save is loaded with this feature enabled.

RusJJ commented 1 year ago

How do they broke? This fix simply adds additional test if ped has zero health

KoremuMekuro commented 1 year ago

How do they broke? This fix simply adds additional test if ped has zero health

Well, as I said, for example with home_brains, peds that you attached to this script dosen't behave like they suppoused to by the script, they behave just like if they wasn't attached to this script, but if I disable this feature, then those attached peds would behave just like they suppoused to by the script.And with missions it's just my assumptions that was based on fact that home_brains just dosen't work with this feature enabled, and the same with my claims about cleo scripts. But anyway, I can just disable this feature as it's not adding or fixing stuff just like I did with slippery floor fix before 1.4.3. And I reported this, cuz slippery floor fix also had issues before 1.4.3 and maybe this one can be also fixed and I don't know c++ and this whole thing with adresses. If no, issue should be closed.

RusJJ commented 10 months ago

Is this still broken?