search

AndroidQuazar / VanillaExpandedFramework

Vanilla Expanded Framework for RimWorld
Other
36 stars 18 forks source link

Allow renaming drones #46

Closed joseasoler closed 2 years ago

joseasoler commented 2 years ago

Drones belonging to the player faction will get a defaulted numbered name after spawning, similar to the name animals get after being tamed or born. Machines in existing savegames before this feature was implemented will get a name after the game is loaded with a newer version of the framework.

A Rename button for drones has been added to the inspect pane, as shown in the screenshot below.

PR

Taranchuk commented 2 years ago

I would just put the rename button in the inspect panel right before the infocard button. Or as a button in the bottom when selecting the bot. It's not really intuitive approach to put the button in the gear tab

legodude17 commented 2 years ago

Fun fact: Vanilla does the first option if an animal is set to not show a training tab.

@joseasoler I'd recommend patching MainTabWindow_Inspect.DoInspectPaneButtons, seems both more straightforward and less likely to confuse users.

joseasoler commented 2 years ago

Thank you for the comments! I am sorry about that review requested message. I was not aware that pushes to my fork would automatically update this PR. I will implement the suggested changes and update the PR again.

Taranchuk commented 2 years ago

Looks all good, I'm merging this