Androidacy / MagiskModuleManager

Previously known as Fox's Magisk Module Manager (FoxMMM), this app helps users find, install "Magisk Modules" - powerful little zips/apps for your device that plug into the Magisk framework.
https://www.androidacy.com
GNU Lesser General Public License v3.0
943 stars 33 forks source link

[BUG] V2 1.0 crashes EVERY time when opening if there is an Upgradable module #19

Closed zgfg closed 1 year ago

zgfg commented 1 year ago

Just observed on both my phones (Xiaomi A11 and A12)

100% reproducible

If there is a single upgradable module, v2.1.0 crashes when opening

I have submitted several crash reports by mail

If I upgrade a module from Magisk app, then afterwards v2.1.0 opens

But if I downgrade again some module (eg, uninstall and install an older version from Alt Repo), then your app crashes again when I open / restart v2.1.0 Screenshot_2023-05-10-07-45-41-217_com fox2code mmm

fontanelas commented 1 year ago

Same here on Redmi Note 8T (Willow)

fontanelas commented 1 year ago

It happens when it's checking the modules for updates.

Registro de falhas: java.lang.ArrayIndexOutOfBoundsException: length=1; index=1 at n11.e(SourceFile:215) at z11.d(SourceFile:154) at io.sentry.n2.c(SourceFile:509) at io.sentry.n2.d(SourceFile:92) at jm0.run(SourceFile:67)

Alphasee commented 1 year ago

OnePlus 8T, A13 Same issue as original poster and same error log as fontenelas.

Tried to race condition disable all settings before crashing, but it doesn't seem to be theme/settings related. Deleted magisk entry. Cleared cache and data, tried uninstall and reinstall. 1.1 works with module updates, v2 and most recent update throw errors when updates available.

If it helps, my modules are not in alt or Androidacy repos as far as I can tell. Can confirm updating through magisk directly allows app to function.

Confirmed it is not related to my version of WebView. Had Beta enabled, reverted to system version. No other app updates available, and running the May 5th security patch. Error also occurs when trying to load module descriptions:

Stacktrace: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.fox2code.mmm/com.fox2code.mmm.markdown.MarkdownActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setBackgroundColor(int)' on a null object reference at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3642) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3779) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:138) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2304) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7926) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:942) Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setBackgroundColor(int)' on a null object reference at com.fox2code.mmm.markdown.MarkdownActivity.P(SourceFile:25) at com.fox2code.mmm.markdown.MarkdownActivity.onCreate(SourceFile:270) at android.app.Activity.performCreate(Activity.java:8365) at android.app.Activity.performCreate(Activity.java:8344) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1424) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3623) ... 12 more

androidacy-user commented 1 year ago

Fixed in 1a45f98.

Please report different issues in different issue threads.