Androidacy / MagiskModuleManager

Previously known as Fox's Magisk Module Manager (FoxMMM), this app helps users find, install "Magisk Modules" - powerful little zips/apps for your device that plug into the Magisk framework.
https://www.androidacy.com
GNU Lesser General Public License v3.0
943 stars 33 forks source link

[BUG] Hitting a snag when trying to install a module #2

Closed zgfg closed 1 year ago

zgfg commented 1 year ago

Just installed the new AA MMM v2.0.2, and I have again the same bug as previously reported for Fox MMM v2.0.1 (it was fixed in one of the Action builds and I successfully tested): https://github.com/Fox2Code/FoxMagiskModuleManager/issues/309

But now again, when I try to install any module from the online Repo (Alt Repo), I get "Hitting a snag" and the installation of the module fails

Tried also with an Upgradable module, the same

Same bug also when I downloaded a module and tried to install the module zip file from the local storage (Download folder) Screenshot_2023-05-03-11-01-32-124_com fox2code mmm

androidacy-user commented 1 year ago

We are tracking this internally and via Sentry and will update when we can reproduce.

mrkylegp commented 1 year ago

I have the same problem. Redmagic 8 Pro, android 13.

Can't use v2.0.2. V1 works fine.

zgfg commented 1 year ago

We are tracking this internally and via Sentry and will update when we can reproduce.

You can't reproduce? Try to install any module from the repo or from your local storage

androidacy-user commented 1 year ago

We are tracking this internally and via Sentry and will update when we can reproduce.

You can't reproduce? Try to install any module from the repo or from your local storage

Both of which are working completely fine on our test devices and emulators. Rest assured our developers do know how to reproduce a problem 😉

androidacy-user commented 1 year ago

This bug only seems to be effecting 0.01-0.1% of users making it rather hard to reproduce

mrkylegp commented 1 year ago

This bug only seems to be effecting 0.01-0.1% of users making it rather hard to reproduce

That seems odd. What would the variance be in Android 13 that would only affect such a small number of users I wonder.

giving-sesame commented 1 year ago

I have the same problem. I reported the bug via application's form. I'd like to add that after such a problem occured I cannot run the application normally without clearing the data.

Redmi 9, Android 11.

No module can be installed.

zgfg commented 1 year ago

I can reproduce any time with my both phones, Android 11 and Android 12

The same bug was introduced in v2.0.1 and you fixed it in the Action build> https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4826124597

So please compare what got wrong in the later changes before releasing v2.0.2

badassaccount commented 1 year ago

I also encounter this bug both local storage and Online install. My Device was Poco MIUI 13

Stacktrace: java.lang.ExceptionInInitializerError at hj2.a(SourceFile:10) at hj2.g(SourceFile:1) at hj2.i(SourceFile:223) at hj2.setTime(SourceFile:34) at xj2.k(SourceFile:532) at xj2.(SourceFile:105) at p70.c(SourceFile:73) at com.fox2code.mmm.installer.InstallerActivity.L(SourceFile:234) at lm0.run(Unknown Source:14) at java.lang.Thread.run(Thread.java:1012) Caused by: java.lang.IllegalArgumentException: class je is not a concrete class at m60.c(SourceFile:59) at m60.(SourceFile:10) ... 10 more

I hope it will fix soon, kodos to developers.

raulvasquez commented 1 year ago

Same problem here as well.

androidacy-user commented 1 year ago

To address the real issue here we are completely aware of what the error says, but as we've mitigated that error for ages and the crash occurs for less than 1% of users and on none of our test devices or emulators we're having a hard time coming up with solutions.

zgfg commented 1 year ago

To address the real issue here we are completely aware of what the error says, but as we've mitigated that error for ages and the crash occurs for less than 1% of users and on none of our test devices or emulators we're having a hard time coming up with solutions.

Saying again, see above, compare against one of the Action builds between v2 0 1 and v2.0.2 where it worked (already for the v2 code base)

androidacy-user commented 1 year ago

To address the real issue here we are completely aware of what the error says, but as we've mitigated that error for ages and the crash occurs for less than 1% of users and on none of our test devices or emulators we're having a hard time coming up with solutions.

Saying again, see above, compare against one of the Action builds between v2 0 1 and v2.0.2 where it worked (already for the v2 code base)

That's the commit that has the mitigation I'm referring to that doesn't seem to suffice for builds with proguard enabled. We're hoping to do a rather large code refactor that will probably get rid of the race condition that could be causing this but we put off the refactor in order to get 2.0.2 out the door to resolve a few more major bugs with 2.0.1

Avsynthe commented 1 year ago

Experiencing the same issue on an Asus ROG Phone II running A11. I thought it might be a shamiko issue at first as that's the only upgrade I have. Can confirm it doesn't matter if I attempt from repo or storage.

I've had two different errors appear for me though, though after resetting the app I received the one listed here and it's stayed that way. If I can reproduce the first error I'll post here.

LeeBinder commented 1 year ago

Debug apks from Actions in which this bug is fixed (at least for me on my phone with LOS 17.1/ Android 10): https://github.com/Androidacy/MagiskModuleManager/actions/runs/4898981912#artifacts

Kudos to you, @androidacy-user , for the quick fix 👍 🥇

zgfg commented 1 year ago

I have just tested Action build: https://github.com/Androidacy/MagiskModuleManager/actions/runs/4898981912

and it works - thanks

ChaliceChore commented 1 year ago

Debug apks from Actions in which this bug is fixed: https://github.com/Androidacy/MagiskModuleManager/actions/runs/4898981912#artifacts

Thanks, this works. Device: OnePlus 7 Pro OS: PixelExperience v13.0-20230423-0143-OFFICIAL

Albirew commented 1 year ago

did this bug came back? On 2.1.1(74) when trying to update a module (either inline update or update from file), i get the same error:

Snag ``` Pile: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.fox2code.mmm/com.fox2code.mmm.installer.InstallerActivity}: java.lang.ClassCastException: com.google.android.material.floatingactionbutton.ExtendedFloatingActionButton cannot be cast to zh at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3649) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3786) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:138) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2311) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7903) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ExecInit.main(ExecInit.java:49) at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method) at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:355) Caused by: java.lang.ClassCastException: com.google.android.material.floatingactionbutton.ExtendedFloatingActionButton cannot be cast to zh at com.fox2code.mmm.installer.InstallerActivity.onCreate(SourceFile:377) at android.app.Activity.performCreate(Activity.java:8388) at android.app.Activity.performCreate(Activity.java:8367) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1422) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3630) ... 14 more ```

I did tried the latest artifact but cannot confirm since module doesn't appear in updates ("update available" but doesn't show said module, even when searching) and when file updating, it silently fails (goes back to main menu).

ChaliceChore commented 1 year ago

Yeah, I too am facing this issue. Reinstalling either v2.1.1 or v2.1.0 doesn't fix it.

Albirew commented 1 year ago

nevermind, they updated their apk, but only outside github (witch is somehow concerning since they can just edit release and replace apk file)

LeeBinder commented 1 year ago

@Albirew 100% agreed. I've recommended that exact same thing before, here. But such remarks aren't considered helpful and rational but much rather spam, see the reply a few post later in that same (and since then locked) topic ..

ChaliceChore commented 1 year ago

nevermind, they updated their apk, but only outside github (witch is somehow concerning since they can just edit release and replace apk file)

I tried apk from there. Still 'hitting a snag '.

LeeBinder commented 1 year ago

@iamMG it's a DIFFERENT app, adding a 2nd FoxMM icon into your launcher's app list! You need to remove the old non-functional one here from GitHub so that you can ONLY launch the app from their website via ITS icon!

(all of this is free open-source so we may not expect professionalism, I guess)

androidacy-user commented 1 year ago

@iamMG it's a DIFFERENT app, adding a 2nd FoxMM icon into your launcher's app list! You need to remove the old non-functional one here from GitHub so that you can ONLY launch the app from their website via ITS icon!

(all of this is free open-source so we may not expect professionalism, I guess)

Unless you're installing a debug build from GitHub, there will be one icon.

androidacy-user commented 1 year ago

did this bug came back? On 2.1.1(74) when trying to update a module (either inline update or update from file), i get the same error:

Snag ``` Pile: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.fox2code.mmm/com.fox2code.mmm.installer.InstallerActivity}: java.lang.ClassCastException: com.google.android.material.floatingactionbutton.ExtendedFloatingActionButton cannot be cast to zh at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3649) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3786) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:138) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2311) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7903) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ExecInit.main(ExecInit.java:49) at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method) at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:355) Caused by: java.lang.ClassCastException: com.google.android.material.floatingactionbutton.ExtendedFloatingActionButton cannot be cast to zh at com.fox2code.mmm.installer.InstallerActivity.onCreate(SourceFile:377) at android.app.Activity.performCreate(Activity.java:8388) at android.app.Activity.performCreate(Activity.java:8367) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1422) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3630) ... 14 more ```

I did tried the latest artifact but cannot confirm since module doesn't appear in updates ("update available" but doesn't show said module, even when searching) and when file updating, it silently fails (goes back to main menu).

This bug is fixed in development but we have some tidying up to do before the next release.

LeeBinder commented 1 year ago

@androidacy-user one icon for the GitHub "debug" build, + one (another) icon for the build from your website which even has a different signature (labeled "signed") = TWO icons, for sure. You can test it yourself :)

androidacy-user commented 1 year ago

@Albirew 100% agreed. I've recommended that exact same thing before, here. But such remarks aren't considered helpful and rational but much rather spam, see the reply a few post later in that same (and since then locked) topic ..

Has nothing to do with the remarks itself but the repeated reporting of the same issue. We've already explained our reasoning and provided a fixed rebuild.

androidacy-user commented 1 year ago

@androidacy-user one icon for the GitHub "debug" build, + one (another) icon for the build from your website which even has a different signature (labeled "signed") = TWO icons, for sure. You can test it yourself :)

It doesn't have a different signature, lol. We used the same signing keys. And, like I said:

Unless you're installing a debug build

LeeBinder commented 1 year ago

@androidacy-user :

No "debug" builds to be seen..

PLEASE for heaven's sake, DO test yourself. What you're writing simply is NOT reflected by reality!!

androidacy-user commented 1 year ago

@androidacy-user :

No "debug" builds to be seen..

PLEASE for heaven's sake, DO test yourself. What you're writing simply is NOT reflected by reality!!

First is GitHub release, second is website ![Screenshot_20230619-085144.png](https://github.com/Androidacy/MagiskModuleManager/assets/45006100/542b396a-4ad0-41be-bd95-f607fcf090c9) ![Screenshot_20230619-085144.png](https://github.com/Androidacy/MagiskModuleManager/assets/45006100/808d5bd8-fb24-48ed-986d-6d71c0c1d177) ![Screenshot_20230619-085155.png](https://github.com/Androidacy/MagiskModuleManager/assets/45006100/75b5edf7-8c96-4a27-9fdd-75eb28b858b3) ![Screenshot_20230619-085202.png](https://github.com/Androidacy/MagiskModuleManager/assets/45006100/3e516fa1-93ca-4979-9e91-664eb9843484)

The situation you described of two icons can LITERALLY only happen if you've installed a debug build from GitHub actions, because it has a different package name and signature.

Albirew commented 1 year ago

No "debug" builds to be seen..

Debug builds are on github actions page (see green check items subtitled with "Generate APK Debug", then scroll on artifacts), not on release page

scrattatattat commented 1 year ago

Still not working in September 23, and ongoing since May, bit ridiculous if you ask me. What are you guys actually doing over there? All you have to do is maintain stuff, we are the ones that do the real work and development, and you charge us for it. For what? Cant even access our own published works

androidacy-user commented 1 year ago

Still not working in September 23, and ongoing since May, bit ridiculous if you ask me. What are you guys actually doing over there? All you have to do is maintain stuff, we are the ones that do the real work and development, and you charge us for it. For what? Cant even access our own published works

Excuse me, what "real work and development" are you referring to? Because I sure don't see you contributing to this app.

The app works completely fine for everyone else as of 2.3.1. Maybe if you still have issues, you should open up a different issue with appropriate logs?