Androidacy / MagiskModuleManager

Previously known as Fox's Magisk Module Manager (FoxMMM), this app helps users find, install "Magisk Modules" - powerful little zips/apps for your device that plug into the Magisk framework.
https://www.androidacy.com
GNU Lesser General Public License v3.0
907 stars 31 forks source link

Why does AMM request root privilege in the background so often? #54

Closed ruralTom closed 1 year ago

ruralTom commented 1 year ago

I don't recall FMM doing it.

Is AMM doing stuff other than insalling modules in the background or something? If so what? I don't want to freeze it if it needs to do work.

androidacy-user commented 1 year ago

I don't recall FMM doing it.

Is AMM doing stuff other than insalling modules in the background or something? If so what? I don't want to freeze it if it needs to do work.

Due to a bug in libsu, for some users the module background check will crash continuously. We believe we've mitigated the issue for most users but you can always shut off the check until we either hear back from the library maintainers or find a full workaround.

ruralTom commented 1 year ago

Thank you. I have automatic updates off now, but still have 'check for updates' checked. It seems okay for now, I'll try unchecking all updates if it comes back.

I do notice NL Sound shows as updatable, but it's an involved set up full of user choices - do you think trying to update that automatically could be part of the issue?

Jul 9, 2023 7:20:03 PM Androidacy Service Account @.***>:

I don't recall FMM doing it.

Is AMM doing stuff other than insalling modules in the background or something? If so what? I don't want to freeze it if it needs to do work.

Due to a bug in libsu, for some users the module background check will crash continuously. We believe we've mitigated the issue for most users but you can always shut off the check until we either hear back from the library maintainers or find a full workaround.

— Reply to this email directly, view it on GitHub[https://github.com/Androidacy/MagiskModuleManager/issues/54#issuecomment-1627975217], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AG4SSAGM5OLH5DFJS5KYMO3XPNRFDANCNFSM6AAAAAA2D37ZQU]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AG4SSACMAUBUMWKOVVKKU5LXPNRFDA5CNFSM6AAAAAA2D37ZQWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTBBDXDC.gif]

androidacy-user commented 1 year ago

Thank you. I have automatic updates off now, but still have 'check for updates' checked. It seems okay for now, I'll try unchecking all updates if it comes back. I do notice NL Sound shows as updatable, but it's an involved set up full of user choices - do you think trying to update that automatically could be part of the issue? Jul 9, 2023 7:20:03 PM Androidacy Service Account @.***>: I don't recall FMM doing it. Is AMM doing stuff other than insalling modules in the background or something? If so what? I don't want to freeze it if it needs to do work. Due to a bug in libsu, for some users the module background check will crash continuously. We believe we've mitigated the issue for most users but you can always shut off the check until we either hear back from the library maintainers or find a full workaround. — Reply to this email directly, view it on GitHub[#54 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AG4SSAGM5OLH5DFJS5KYMO3XPNRFDANCNFSM6AAAAAA2D37ZQU]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AG4SSACMAUBUMWKOVVKKU5LXPNRFDA5CNFSM6AAAAAA2D37ZQWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTBBDXDC.gif]

Updates for modules are not fully automated and never will be. For now, the issue has been mitigated and should be resolved in 2.2.3 releasing soon.

chrcoluk commented 9 months ago

I solved it by telling Android to not let the app run in the background, there is no reason for the app to be doing stuff in the background (I disabled update checking).

androidacy-user commented 9 months ago

I solved it by telling Android to not let the app run in the background, there is no reason for the app to be doing stuff in the background (I disabled update checking).

The issue is already resolved for a few versions now, anyway