Androidacy / MagiskModuleManager

Previously known as Fox's Magisk Module Manager (FoxMMM), this app helps users find, install "Magisk Modules" - powerful little zips/apps for your device that plug into the Magisk framework.
https://www.androidacy.com
GNU Lesser General Public License v3.0
907 stars 31 forks source link

Implement KernelSU module support #61

Closed ItsLynix closed 1 year ago

ItsLynix commented 1 year ago

The problem needing a solution AMM right now only supports magisk, and even if other root solutions such as KernelSU support magisk modules, AMM looks for magisk specific paths and binaries to install them, hence not supporting KernelSU.

Possible Solution Since KernelSU already essentially supports magisk modules, I imagine it wouldn't be that hard to add its ksud cli binary to install modules with it.

Additional context I tried to build this in a jerryrigged way myself here but I feel I messed it up and gave up.

Context: kernelsu can install modules by calling /data/adb/ksu/bin/ksud module install ZIP_PATH_HERE and also has a busybox binary bundled at /data/adb/ksu/bin/busybox incase you need it for your ash runner during the install process.

androidacy-user commented 1 year ago

We currently depend on features we can only be certain are available with magisk.

While we haven't ruled out KernelSU support, it's not currently on the roadmap.

androidacy-user commented 1 year ago

Experimental support has landed in master. We'll continue expanding support and using user feedback to improve it, but not all functionality may work correctly without magisk.

androidacy-user commented 1 year ago

2.3.0 includes experimental support for KernelSU. Feedback is welcome but we cannot provide support for incompatible modules.