search

Androidacy / MagiskModuleManager

Previously known as Fox's Magisk Module Manager (FoxMMM), this app helps users find, install "Magisk Modules" - powerful little zips/apps for your device that plug into the Magisk framework.
https://www.androidacy.com
GNU Lesser General Public License v3.0
907 stars 31 forks source link

[BUG] F-Droid can't build #70

Closed licaon-kter closed 1 year ago

licaon-kter commented 1 year ago

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/5064858593#L800

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/b4297bdb948b0d5fabbd42e5704d87b127234b31

androidacy-user commented 1 year ago

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/5064858593#L800

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/b4297bdb948b0d5fabbd42e5704d87b127234b31

Your build modifies SentryMain in a way that breaks it. We have no intention of fixing it until you do.

Besides, I don't know why you hard disable sentry. It's off by default unless the user opts in - which complies with your policies.

androidacy-user commented 1 year ago

Your script also removes components related to updates for the app, which are also disabled on fdroid builds.

Unless you can prove it doesn't build with our sources - which shouldn't happen because CI checks that fdroid still builds on release builds every new version - we consider this an issue on your end.

licaon-kter commented 1 year ago

The sed patching was added as needed at that point in time, we'll see if they still apply.

linsui commented 1 year ago

I removed sentry in 2.3.0 because it doesn't build with that enabled. :shrug: https://gitlab.com/fdroid/fdroiddata/-/jobs/5051237358

sentry reported an error: Authentication credentials were not provided. (http status: 401)
androidacy-user commented 1 year ago

I removed sentry in 2.3.0 because it doesn't build with that enabled. :shrug: https://gitlab.com/fdroid/fdroiddata/-/jobs/5051237358

sentry reported an error: Authentication credentials were not provided. (http status: 401)

That should have been resolved with 2.3.1

linsui commented 1 year ago

Let me have a try.

androidacy-user commented 1 year ago

Let me have a try.

Let us know how it goes 👍

linsui commented 1 year ago

https://gitlab.com/linsui/fdroiddata/-/jobs/5077658861 It failed again.

androidacy-user commented 1 year ago

https://gitlab.com/linsui/fdroiddata/-/jobs/5077658861 It failed again.

Weird. Sentry must have changed something in the last Gradle plugin release

Try now / https://github.com/Androidacy/MagiskModuleManager/commit/1d2144d8c48f05bc1962fa2b2ab6ae36ffe978af

linsui commented 1 year ago

It works, thanks!