search

Androidacy / MagiskModuleManager

Previously known as Fox's Magisk Module Manager (FoxMMM), this app helps users find, install "Magisk Modules" - powerful little zips/apps for your device that plug into the Magisk framework.
https://www.androidacy.com
GNU Lesser General Public License v3.0
907 stars 31 forks source link

[BUG] Crashes upon startup #77

Closed gaining closed 11 months ago

gaining commented 11 months ago

Describe the bug Crashes as the app opens

To Reproduce Tap app icon, windows opens with "Hit a snag" with error code:

Stacktrace: java.lang.NullPointerException: Attempt to invoke virtual method 'void t21.g(java.lang.String java.util.HashMap)' on a null object reference at jw0.run(Unknown Source:582) at java.lang.Thread.run(Thread.java:919)

Expected behavior Being able to use app after opening.

Screenshots Screenshot_20231001-183635

Device info(please complete the following information):

Additional context Add any other context about the problem here.

androidacy-user commented 11 months ago

Do you have analytics disabled? We are aware of issues with analytics disabled, due to insufficient checks that are already fixed in the latest actions builds

marcdw1289 commented 11 months ago

Confirmed. With analytics off it crashes. After clearing data and starting over from the initial setup screen, toggling a repo also resulted in a crash. Had to make sure to enable analytics first before doing anything else.

gaining commented 11 months ago

Do you have analytics disabled? We are aware of issues with analytics disabled, due to insufficient checks that are already fixed in the latest actions builds

Now that you mention this, I might've disabled analytics a few years ago. But most apps work without it

androidacy-user commented 11 months ago

Do you have analytics disabled? We are aware of issues with analytics disabled, due to insufficient checks that are already fixed in the latest actions builds

Now that you mention this, I might've disabled analytics a few years ago. But most apps work without it

App analytics was reworked in v2.3 to use a more robust and privacy preserving solution. When it was integrated, not all code checked that analytics was opted in to, meaning that if it wasn't, the SDK wasn't set up, and trying to send an event crashes.

MrNRod commented 11 months ago

Stacktrace: java.lang.NullPointerException: Attempt to invoke virtual method 'void t21.g(java.lang.String java.util.HashMap)' on a null object reference at jw0.run(Unknown Source:582) at java.lang.Thread.run(Thread.java:1012)

Getting the same issue with Analytics disabled on 2.3.3 downloaded from fdroid

androidacy-user commented 11 months ago

Stacktrace: java.lang.NullPointerException: Attempt to invoke virtual method 'void t21.g(java.lang.String java.util.HashMap)' on a null object reference at jw0.run(Unknown Source:582) at java.lang.Thread.run(Thread.java:1012)

Getting the same issue with Analytics disabled on 2.3.3 downloaded from fdroid

This is fixed in 2.3.4. I have no idea when fdroid will update.