search

Androidacy / MagiskModuleManager

Previously known as Fox's Magisk Module Manager (FoxMMM), this app helps users find, install "Magisk Modules" - powerful little zips/apps for your device that plug into the Magisk framework.
https://www.androidacy.com
GNU Lesser General Public License v3.0
909 stars 33 forks source link

[IMPROVEMENT] Confusing Upgradable badge #8

Closed zgfg closed 1 year ago

zgfg commented 1 year ago

When there is an Upgradable module, badge shows on the Online icon

But when you open Online tab, there is no list of Upgradable modules - confusing IMO

List of Upgradable modules is displayed in the Installed tab (I think that is correct)

But then please move the badge (number of Upgradable modules) also from Online icon to Installed icon _Online _Installed

androidacy-user commented 1 year ago

Upgradable modules are only supposed to be shown in online tab, but we have not experimented with that with modules only updatable via updateJSON so that probably needs tweaked

zgfg commented 1 year ago

Yes - the module in my case was not available on the Repo but locally installed and upgradable by updateJson

I have just tested (latest Action build - I was testing the fix for crash on the module installation) the case when module is upgradable from Repo and in that case the Upgradable module is listed in the Online tab

androidacy-user commented 1 year ago

I'm going to consider this issue closed even if by happy accident.

zgfg commented 1 year ago

I'm going to consider this issue closed even if by happy accident.

By which Action build it can be tested?

Daviteusz commented 1 year ago

Upgradable modules are only supposed to be shown in online tab, but we have not experimented with that with modules only updatable via updateJSON so that probably needs tweaked

In my opinion, the module update badge should appear on the installed tab. The section of separated modules for updating is just in this tab. This is very confusing.

The badge on online tab can be when there is a new module in the repository.

Alternatively, the update section could be moved to the online tab, but this is probably not a good idea

androidacy-user commented 1 year ago

Upgradable modules are only supposed to be shown in online tab, but we have not experimented with that with modules only updatable via updateJSON so that probably needs tweaked

In my opinion, the module update badge should appear on the installed tab. The section of separated modules for updating is just in this tab. This is very confusing.

The badge on online tab can be when there is a new module in the repository.

Alternatively, the update section could be moved to the online tab, but this is probably not a good idea

In order to be upgradable it has to be from online, hence the decision to have it in the online tab.

It's not easy to track when new modules are added as the repo cache system would have to be redesigned, and it's already fragile enough trying to support every possible repo.