Androidacy / MagiskModuleManager

Previously known as Fox's Magisk Module Manager (FoxMMM), this app helps users find, install "Magisk Modules" - powerful little zips/apps for your device that plug into the Magisk framework.
https://www.androidacy.com
GNU Lesser General Public License v3.0
907 stars 31 forks source link

[BUG] Cannot manually install a downloaded modules from AMM itself #86

Closed devCKVargas closed 9 months ago

devCKVargas commented 10 months ago

Describe the bug I always download to storage first before install. It won't let me do that starting from 2.3.x so I stayed on 2.2.3 but it's not working anymore so I decided to try 2.3.2 - 2.3.4 nothing worked.

To Reproduce Steps to reproduce the behavior:

  1. Install module from storage
  2. Select a module downloaded from AMM app itself

Expected behavior A clear and concise description of what you expected to happen. It should proceed to install like normal

Screenshots Screenshot_20231022-063548_Androidacy Module Manager.png

Screenshot_20231022-063445_Androidacy Module Manager.png

Device info(please complete the following information):

Additional context logs.txt

androidacy-user commented 10 months ago

If you would like to help us pin down this issue, please share logs from debugging options with the latest GitHub Actions debug build.

devCKVargas commented 10 months ago

If you would like to help us pin down this issue, please share logs from debugging options with the latest GitHub Actions debug build.

Here's the log from the latest debug build. logs.txt

Screenshot_20231029-063706_Androidacy Module Manager.png

ntfc commented 10 months ago

I've found the same thing with version 2.3.4, and it seems that ZIPs downloaded from androidacy are corrupt/not completed.

devCKVargas commented 9 months ago

I've found the same thing with version 2.3.4, and it seems that ZIPs downloaded from androidacy are corrupt/not completed.

Using another file explorer to select the module seemed to recognize it fine.

Closing this as it's been fixed in the latest v2.3.5.

androidacy-user commented 9 months ago

I've found the same thing with version 2.3.4, and it seems that ZIPs downloaded from androidacy are corrupt/not completed.

There was a bug in the zip validation logic that was fixed in 2.3.5

ntfc commented 9 months ago

It seems my issues is with downloading the ZIP from androidacy, regardless of 2.3.4 or 2.3.5 (am using 2.3.5 now anyway).

For example, the ZIP for the microG Installer Revived version 3.4.1-0 downloaded from https://www.androidacy.com/magisk-modules-repository/#microg_installer never matches the expected sha256 checksum. Seems like the download is aborted at somewhere around 30Mb but I can't tell if it is specific to this module, my connection or the server itself. Anything you can double check here @androidacy-user ?

androidacy-user commented 9 months ago

It seems my issues is with downloading the ZIP from androidacy, regardless of 2.3.4 or 2.3.5 (am using 2.3.5 now anyway).

For example, the ZIP for the microG Installer Revived version 3.4.1-0 downloaded from https://www.androidacy.com/magisk-modules-repository/#microg_installer never matches the expected sha256 checksum. Seems like the download is aborted at somewhere around 30Mb but I can't tell if it is specific to this module, my connection or the server itself. Anything you can double check here @androidacy-user ?

So far, only a few people are reporting issues. I personally just checked and it was fine