Androidacy / WebviewManager-Module

WebView Manager is a magisk module to change your webview and browser to one of your choice.
https://www.androidacy.com
Other
85 stars 7 forks source link

[BUG] WvM not functional on LineageOS 17.1 microG on Samsung S9+ #16

Closed MichaelZ4714 closed 2 years ago

MichaelZ4714 commented 2 years ago

Describe the bug After installing WebviewManager-Module with Bromite Webview the new webview is not used and not functional.

To Reproduce Steps to reproduce the behavior:

  1. Boot into recovery (TWRP 3.6.1), full wipe, install LOS 17.1, boot into system
  2. LOS first startup configuration (language, wifi etc.), activate Developer Options
  3. Install Magisk 24.3, patch boot.img, boot into recovery
  4. Install patched boot.img, boot into system
  5. Install WebviewManager-Module in Magisk (only webview, using Bromite), boot into system
  6. System settings Developer Options: Bromite Webview is not active and can't be activated
  7. Install X-Plore and transfer files for report as root

Expected behavior Bromite Webview is active in Developer options or can be activated. On my reserve device Samsung S4 (GT-I9505, jfltexx) having the same system environment it works as expected.

Desktop (please complete the following information):

Additional context The file having full log is attached full-2022-03-27-10.10.56.log

The folders /data/adb/modules/bromitewebview and /sdcard/WebviewManager and the file /data/system/overlays.xml are available on https://zoellner.selfhost.de/public/Android/WebviewManager/

androidacy-user commented 2 years ago

Your magisk environment seems to be messed up. $MODPATH isn't being set in the installation environment.

Please try reinstalling magisk, as that may help.

MichaelZ4714 commented 2 years ago

Have many thanks for this input. I did reinstall Magisk 24.3 and then installed WebviewManager again. Still the same result.

Then I added the diagnostic output ui_print "MODPATH is $MODPATH " in common/install.sh at the beginning of the script and at the beginning of create_overlay(). At both places it gave the output MODPATH is /data/adb/modules_update/bromitewebview when reinstalling. Could you please tell me where the variable is missing?

MichaelZ4714 commented 2 years ago

I further investigated and I think it might not be a problem with WebviewManager but with the custom rom. It could be that LineageOS for microG for the star2lte Samsung S9+ is configured a little different than the one for the jfltexx Samsung S4. On the malfunctioning device S9+ the output of cmd overlay dump shows mState: STATE_NO_IDMAP whereas on the S4 it is mState: STATE_ENABLED_STATIC as it should be. I try to find out why the overlay is loaded but can't be activated.

MichaelZ4714 commented 2 years ago

The statement in above comment was not correct. Somehow I forgot to start over with a fresh clean OS install. After I did a wipe of Dalvik/ART Cache and Cache in TWRP the state of the overlay was STATE_ENABLED_STATIC and the resource map /data/resource-cache/product@overlay@WebviewOverlay.apk@idmap could be dumped with idmap2 and showed correct id mapping. But still the Bromite Webview was not available. This further enhances the assumption that it's a problem with the rom. Could an admin please close this topic as I don't see a way to do it.