Androidacy / WebviewManager-Module

WebView Manager is a magisk module to change your webview and browser to one of your choice.
https://www.androidacy.com
Other
83 stars 9 forks source link

Enable increasing volume keys timeout for accessibility #17

Closed PatrykMis closed 1 year ago

PatrykMis commented 2 years ago

Is your feature request related to a problem? Please describe. Blind and/or visually impaired people using TalkBack screenreader have not enough time to read screen contents, thus module is installing with partial or over all defaults.

Describe the solution you'd like Few ideas:

  1. Ability to define volume keys timeout in configuration file. or
  2. Enable to define all installation parameters in configuration file and make it useable (config file currently doesn't work properly). or
  3. Set timeout in instalation script for at least 15 seconds (absolute minimum).

Describe alternatives you've considered None despite above.

Additional context None despite above.

github-actions[bot] commented 2 years ago

Thanks for your contribution! Please keep in mind we will get to this issue when we have a chance. Logs and device information are mandatory if you do not want your issue closed without response.

androidacy-user commented 2 years ago

We're already planning on improving the volume key installation but 15 seconds * 3 (that's how many times it should try) would mean 45 seconds of wait time for it to fall back to the configuration file. We don't intend to make the configuration file the primary form of configuration as it's not as flexible, especially for the direction we plan on taking the module.

That being said, as I mentioned, there's definitely room for improvement, and any accessibilities feedback is appreciated as we don't have reliable ways of testing accessibility yet.

PatrykMis commented 2 years ago

What is 45 or even 60 seconds? Nothing. The fact is that you are not installing it twice a day but once at all. Second fact is that there are really few devices where volume keys are not working, personally I don't know any.

shapeshifterincontext commented 2 years ago

Second fact is that there are really few devices where volume keys are not working, personally I don't know any.

I came here searching for an alternative solution and saw your comment and thought I'd reply. My device (SM-T800) refuses to use the volume keys when installing this module.

PatrykMis commented 2 years ago

It doesn't change that 45 seconds is not long especially when you are not installing it twice a day but (including updates conditionally) once a month, or once at all.

Btw. No interest - no monthly donations. I stopped using Magisk and root a while ago, and Vanadium WebView is enough for me. If it is that huge problem to resolve it, then…

androidacy-user commented 1 year ago

Closing issue as it's considered resolved in the last release. TImeout was not increased to the extent requested but was increased to the point most reports seem resolved.


This section is for internal use only Status: In-progress -> Fixed Fixed-In: 10.5.3 Closes-Internal: A-WVM-1098

androidacy-user commented 1 year ago

Config file support will also be majorly reworked in v11 which is under development currently.