search

Androidacy / WebviewManager-Module

WebView Manager is a magisk module to change your webview and browser to one of your choice.
https://www.androidacy.com
Other
85 stars 7 forks source link

Volume keys working incorrectly on install. #8

Closed l4jos closed 2 years ago

l4jos commented 2 years ago

Model: star2lte Magisk: version 23 OS: LineageOS 18.1 unofficial build for star2lte

Hi,

This is not a very big issue because I can install bromitebrowser afterwards, but I struggled with this module to let it install webview.apk and browser.apk. It does not pick up the .apk's for arm64 which I stored in /sdcard/WebviewManager/apks. Defaults are every time returned to Bromite Webview and Chromium browser. When module installer asks me to install chromium AND/OR bromite. I haven't found a way to answer the question correctly, because volume UP did not select (1.)Bromite but shows me the second option (2.chromium). And here it goes weird, because it's installing Chromium Browser which I do not want. Volume UP did not select (1.)Bromite. workaround is to install bromite manually afterwards or skip the question for user interaction or leaving it default by not responding volume up/down button. full-2021-12-01-11_27_15.log

Kind regards, Lajos

github-actions[bot] commented 2 years ago

Thanks for your contribution! Please keep in mind we will get to this issue when we have a chance. Logs and device information are mandatory if you do not want your issue closed without response.

androidacy-user commented 2 years ago

Ah yes Samsung fuckery again. I'll talk to @Zackptg5 see what I can find out, it's his code that handles that.

androidacy-user commented 2 years ago

The browser.apk and webview.apk are no longer used so that part is intended behavior.

Zackptg5 commented 2 years ago

@l4jos Can you save the log after flashing it through magisk managed? the log you attached doesn't show any mmtex output

androidacy-user commented 2 years ago

@l4jos Can you save the log after flashing it through magisk managed? the log you attached doesn't show any mmtex output

We've modified your original logic, logging isn't sent to magisk logs.

The volume keys selector is entirely your own but we use our own fork of mmt-ex.

@l4jos create a file in the root of your internal storage called .androidacy-debug then install. Send /sdcard/WebViewManager/logs/install.log here

l4jos commented 2 years ago

I tried again after creating .androidacy-debug in /sdcard The first question "browser and webview?" accepts power button, the second one ignores power button (as far as I noticed) This sequence I accidentally got degoogled chromium, was not the intention but for sharing install.log

Tbh I do not need this fixed. I just couldn't stand the situation last time and the phone by itself so I felt like sharing a log.

install.log

Zackptg5 commented 2 years ago

I tried again after creating .androidacy-debug in /sdcard The first question "browser and webview?" accepts power button, the second one ignores power button (as far as I noticed) This sequence I accidentally got degoogled chromium, was not the intention but for sharing install.log

Tbh I do not need this fixed. I just couldn't stand the situation last time and the phone by itself (when it ignores the only button that are left on smartphones nowaday) so I felt like sharing a log.

install.log

Hmm, power button shouldn't have responded. Can you run keycheck manually in terminal and echo the output for each volume key? You can grab it from the zip or here

# Move keycheck to somewhere you can execute - ie not /sdcard
# cd to directory you moved it to
chmod +x keycheck
./keycheck
# Press volup key
echo $?
./keycheck
# Press voldown key
echo $?
./keycheck
# Press power key - should do nothing and still wait for input but your device may be weird
echo $? # If applicable

Then post the numbers for each here. Should be 42 for volup and 41 for voldown

androidacy-user commented 2 years ago

What do you mean, the only button left on smartphones? Every device I know of has hardware volume keys, it's why we chose this method

androidacy-user commented 2 years ago

@l4jos we need the logs @Zackptg5 asked for or we'll have to close this issue.

l4jos commented 2 years ago

What do you mean, the only button left on smartphones? Every device I know of has hardware volume keys, it's why we chose this method

I mean there were more buttons in history on telephones.

androidacy-user commented 2 years ago

Closing as we didn't receive the logs requested. If you still need help, open a new issue with the appropriate logs.