search

Andromander / Gaia-Dimension

A mod about a shiny dimension with lore. Made for fun
GNU General Public License v3.0
18 stars 4 forks source link

Waterlogging in mineral water does not function #94

Closed Shedao-Shai closed 3 years ago

Shedao-Shai commented 3 years ago

Versions: 1.16.5-1.3.2

To Reproduce: Steps to reproduce the behavior. This is required for easier diagnosis:

  1. Place any normally waterloggable thing in mineral water, ie stone slabs/stairs or lanterns

Describe the bug Things that are normally able to be waterlogged with vanilla water are not waterloggable in mineral water. Functions similarly to how vanilla water used to work with the block just creating an air pocket in the spaces not covered by the block proper, ie a stair would have one-quarter of the block air and the rest the stair itself rather than water and the stair

Screenshots 2021-03-14_21 22 28

Additional context Observed this behavior on the TF testing server so I apologize if it has already been discovered and fixed

Andromander commented 3 years ago

Unfortunately, due to how Waterlogging works, this isn't possible. This is due to it hard-checking against Water, and the Blockstate itself is a boolean, so it can only be or not be Waterlogged, rather than storing the fluid that it has or doesn't have.