AndromedaOne / 2019Code

2019 Robot Codebase
0 stars 0 forks source link

Spotless #11

Closed themccubbins closed 5 years ago

themccubbins commented 5 years ago

I found this library, spotless, that can do automatic code style checking / fixing using gradle. It can import eclipse style file exports so it's pretty customizable. I was just messing around with it on a local branch but I thought others might want to see what it does. Submitted here as a PR for the team's perusal.

If you want to test it out check out this branch. The build will fail if there are style misses, but you can use the command "./gradlew spotlessApply" to auto-magically fix the issues.

Wouldn't suggest merging this until master is in a fairly stable state (i.e. all open PR's merged) because it changes a lot of formatting in files as you can see. Idea being everyone can pull right after this gets merged so there's not a lot of conflicts everywhere.

Edit: As a bonus, it fixes all the vscode warnings in the build.

fixes #12

Muirrum commented 5 years ago

I went over for a marker and remembered to change my review. Merge this