search

Androz2091 / discord-giveaways-bot

🎁Giveways Bot using the discord-giveaways package
ISC License
202 stars 167 forks source link

{BUG/ERROR} Giveaways Drop crash #99

Closed GeistFighter closed 2 years ago

GeistFighter commented 2 years ago

Hey,

When I run a Drop Giveaways, if a user with the exclude role adds a reaction, the Giveaways counter stops with an error.

Nico105 commented 2 years ago

the error would be?

GeistFighter commented 2 years ago

The error is that it sets the "noWinner" variable directly, so the Giveaway stops, the error is the "noWinner", i don't have a real error, I don't know if that is clear?

Nico105 commented 2 years ago

So only 1 person reacted?

GeistFighter commented 2 years ago

In fact, the problem is that when a person who is normally part of the exclusions reacts, he is counted in the drop as a person who reacts, but is not counted in the fact that he can win, so if there is only one winner on the drop, if the 1st to add the reaction is a person who is part of the exclusions, the drop stops because it takes him into account, but indicates the "NoWinner" because he is excluded, so it would be necessary that the exclusions are also applied to the counter of the Drop reaction.

On the other hand, if there are several winners in the drop, if among the winners there are people excluded, the number of winners will not be equal to the number of winners set.

GeistFighter commented 2 years ago

Oh bruh, I just noticed it now, I opened the bug on the Github of the bot, but it concerns the package itself

GeistFighter commented 2 years ago

https://github.com/Androz2091/discord-giveaways/issues/429