Androz2091 / discord-giveaways

🎉 Complete framework to facilitate the creation of giveaways using discord.js
https://discord-giveaways.js.org
MIT License
335 stars 127 forks source link

✨ end function, noWinnerMessage option #303

Closed Nico105 closed 3 years ago

Nico105 commented 3 years ago

So some people want to send a message in the channel if there is no valid winner in the normal ending. And ik and told people that i can be done with the event but since reroll also has the messages option and technically smth fast enough could come before the event I think it's alright to add this.

But so what confuses me is the original description of giveaway.messages.noWinner = Sent in the channel if there is no valid winner for the giveaway. since it suggest that it should have gotten sent in the channel, but i searched back and this message and description were added in v.3.0.0 but there never was code that sent it in the channel. Even before v.3.0.0 nothing got sent in the channel, so was idk was this just forgotten? Or was it never planned to be sent and the description just ended up like that because of stress?

Anyway since up until now no one complaint, I just changed the description of noWinner and made a separate option (noWinnerMessage) only for the end function which per default is null, so no one gets surprised.

But if someone (looking at androz) can explain the mystery of giveaway.messages.noWinner's description, then that would be nice.