search

Androz2091 / discord-giveaways

🎉 Complete framework to facilitate the creation of giveaways using discord.js
https://discord-giveaways.js.org
MIT License
333 stars 128 forks source link

Update branch discord.js-v13 to use latest v13 version #326

Closed alima566 closed 3 years ago

alima566 commented 3 years ago

Describe the bug

Due to new updates to the master branch of DJS, the casing of thingID properties has changed to thingId (https://deploy-preview-680--discordjs-guide.netlify.app/additional-info/changes-in-v13.html#thing-thingid), which is causing my project to error out.

Error 

  node_modules/discord-giveaways/node_modules/discord.js/typings/index.d.ts:886:12
    886     public ownerID: Snowflake;
                   ~~~~~~~
    'ownerID' is declared here.
Nico105 commented 3 years ago

So are you on the discord.js-v13 branch of this package?

alima566 commented 3 years ago

Yes I am.

Nico105 commented 3 years ago

try updating our branch, that should fix it I think. Cause I updated the required package.json version of dc.js to the v13 branch recently. Before that it was still v12 (required), thats why the error I think. = You still have that installed.

alima566 commented 3 years ago

To update, would I do npm i Androz2091/discord-giveaways#discord.js-v13@latest?

Nico105 commented 3 years ago

npm update discord-giveaways should be enough

alima566 commented 3 years ago

It works now, thanks!