zmkq
commented
3 years ago there is a bug that let MessageID undefined
Closed Nico105 closed 3 years ago
zmkq
commented
3 years ago there is a bug that let MessageID undefined
Nico105
commented
3 years ago there is a bug that let MessageID
undefined
Everything was changed from thingID to thingId, to match discord.js v13
Note: This not yet the new-version-pr for discord-giveaways, since it gets merged into the dev branch first
âš DO NOT UPDATE WHILE "OLD" GIVEAWAYS ARE STILL RUNNING!
Changes
Support for/complete switch to the (coming) v13 version of discord.js
Other
messageIDtomessageIdPR's that could get merged / Things that need to be reviewed
318
315
302
234
(Only when https://github.com/abalabahaha/eris/pull/1216 has no more relevant bugs concerning threads)342
#330 (Exact confirmation needed IMO) (If I get a YES, I will add it)#358359
Basically directed at Androz 😅 Technically this pr can also get merged before those additional prs get merged. Order is up to Androz i guess.
PR's where opinions would be needed (which maybe could get merged)
303 (Not directly v13 related but I mention it anyway)
224 (Wanted or not?)
Basically directed at Androz 😅
Things that I will work on
#324 (I mention this because Idk if smth code related in v13 will be different, so it could also be that it will be just a pr for the normal dev branch)#342Questions
For intents should we useeveryone uses FLAGS apparentlyIntents.FLAGSor is providing strings fine enough?https://github.com/Androz2091/discord-giveaways/issues/338#issuecomment-888352195~~Should we throw an error if the
GUILD_MESSAGE_REACTIONSintent is not provided? Technically it is only necessary for 3 giveaway events (reaction add/remove). So it does not have to be there. But on the other hand people might get confused why they don't receive those 3 giveaway events.~~ Without the intent the reactions cache might be empty => now enforcedNot really directly v13 relevant, but... Should the
giveaway.jsonfile that's currently in the package, which btw also gets published to npm (see package.json), get removed? Cause I don't know the reason why it is there/gets published. If i oversaw something regarding that, pls lmk~~https://support-dev.discord.com/hc/en-us/articles/4404772028055-Message-Content-Access-Deprecation-for-Verified-Bots Regarding that. Should we switch the README command examples over to slash commands? Or maybe remove the current handling without adding slash commands? Since for <100 guild bots it would still be valid but for verified bots not (unless intent, but I dont take that into consideration here, since it should be general)? Or should we just leave it like it is now, since as mentioned, for <100 guild bots its still valid? Lmk your thoughs.~~ #343
A team member in the discord.js server talked about that he will rewrite/adjust the slash example (guide), so we should wait for that for now anyway.(= https://github.com/discordjs/guide/pull/786)the thread channel checker (if statement) you can see in the start command. Should we put it inside a manager _function? Or a getter? Because we already use it in start(), end() and reroll(). = 3 times If "forcing" gets merged it would be +2 = 5. also if "eris" gets merged it would get a bigger block. Or do you think its okay like it is now? EDIT: This might become irrelevant depending on dc.js v13.2. But we have to see.
My thoughts
Did I forgot anything relevant concerning v13 features?
Reviews/opinions would be much appreciated.
Status