embeColor option not working in GiveawayManager#start method

[Shashank3736]

Describe the bug

options.embedColor is not working in GiveawayStartOption.

To Reproduce

Start a giveaway and in options.embedColor put "GREEN"

Expected behavior

A green color in embed for giveaway but receive default one.

Additional context

• discord-giveaways : v5.0.1
• discord.js version: v13.1.0
• Custom Database (if you use one): Mongo DB

Add any other context about the problem here. The problem is there because of validateEmbedColor method. As this method do not allow string embedColor option.

[Shashank3736]

Is there any eta when the new discord-giveaways going to be released with the solution? Currently, we can use the develop branch or send numbers instead of strings, but still having it released on npm will be gr8.

[Tomato6966]

Same thing

I think it's because of Discord.Util.resolveColor returning Something, not changing the value you pass in so it should be something like this:

const validateEmbedColor = (embedColor) => {
    try {
        var embedColorNum = Discord.Util.resolveColor(embedColor);
        if (!isNaN(embedColorNum) && typeof embedColorNum === 'number') return true;
        else return false;
    } catch {
        return false;
    }
};

Proof:

[Nico105]

the fix pr is alread merged in dev

[Nico105]

v5.1.0 has been released