Add Missing Giveaway Events

Androz2091 / discord-giveaways

🎉 Complete framework to facilitate the creation of giveaways using discord.js

https://discord-giveaways.js.org

MIT License

335 stars 127 forks source link

Add Missing Giveaway Events #421

Closed reinacchi closed 2 years ago

reinacchi commented 2 years ago

Changes

This PR adds additional events which currently missing such as:

giveawayCreated
- Fired whenever a new giveaway was created
giveawayEdited
- Fired whenever an existing giveaway was edited
giveawayPaused
- Fired whenever an existing giveaway was paused
giveawayUnpaused
- Fired whenever an existing giveaway was unpaused

Let me know if I missed something in this PR so I can adjust the necessary change.

Status

[x] These changes have been tested and formatted properly.
[ ] This PR includes only documentation changes (JSDoc, README or typings), no code change.
[ ] This PR introduces some breaking changes.

imranbarbhuiya commented 2 years ago

These actions are done by the user, so they know when giveaway is created, edited,... Imo these events aren't necessary.

reinacchi commented 2 years ago

giveawayDeleted and other events exist so it would be better if these are added too and users can easily listen to these events via GiveawaysManager.

Nico105 commented 2 years ago

I also don't really see the need for those but if you care to bother... you would have to put the emit's inside the then's and also at the bottom of the manager file. write a example for jsdocs

reinacchi commented 2 years ago

If you think these aren't necessary, I can close them instead since I don't intentionally want to add something unnecessary either.

Nico105 commented 2 years ago

Unless this gets finished/a demand is voiced, I think this can be closed.