Consistent variable declaration syntax.

Androz2091 / discord-giveaways

🎉 Complete framework to facilitate the creation of giveaways using discord.js

https://discord-giveaways.js.org

MIT License

335 stars 127 forks source link

Consistent variable declaration syntax. #435

Closed Dragonizedpizza closed 2 years ago

Dragonizedpizza commented 2 years ago

Changes

The README uses commas while declaring variables, to declare multiple variables at the top, but it isn't continued later on.

Status

[x] These changes have been tested and formatted properly.
[x] This PR includes only documentation changes (JSDoc, README or typings), no code change.
[ ] This PR introduces some breaking changes.

Nico105 commented 2 years ago

the manager should be left standing out, for better distinction. If a change should be made, then to all const imo.

Cause we can remove the prefix cause our examples are for slash anways now. And remove unnecessary token property then and do client.login(process.env.DISCORD_BOT_TOKEN) instead.

Dragonizedpizza commented 2 years ago

How about now?

imranbarbhuiya commented 2 years ago

Imo the const related change isn't needed. You are just saving 4 letters. But writing const twice is much ux friendly and I prefer it for readability.