feat: add Giveaway param in exemptmember

Androz2091 / discord-giveaways

🎉 Complete framework to facilitate the creation of giveaways using discord.js

https://discord-giveaways.js.org

MIT License

335 stars 127 forks source link

feat: add Giveaway param in exemptmember #452

Closed imranbarbhuiya closed 2 years ago

imranbarbhuiya commented 2 years ago

Changes

This pr adds Giveaway param in exemptMembers function.

Ik we've new Function(), where we can access this, but when using new Function() all our javascript code becomes a string and that's why our ide/typescript can't show errors. Also, everyone doesn't know how to make new Function() async.

Status

[x] These changes have been tested and formatted properly.
[ ] This PR includes only documentation changes (JSDoc, README or typings), no code change.
[ ] This PR introduces some breaking changes.

Nico105 commented 2 years ago

btw for consistency you could also add the param for bonusEntry functions, if you want.

imranbarbhuiya commented 2 years ago

btw for consistency you could also add the param for bonusEntry functions, if you want.

I haven't checked any bonus entry-related codes yet so idk how it works and I don't have time to check all the bonus entries related codes. If anyone else is interested then go-ahead

Nico105 commented 2 years ago

btw for consistency you could also add the param for bonusEntry functions, if you want.

I haven't checked any bonus entry-related codes yet so idk how it works and I don't have time to check all the bonus entries related codes. If anyone else is interested then go-ahead

np. i will do it when i have time then.