Androz2091 / discord-giveaways

🎉 Complete framework to facilitate the creation of giveaways using discord.js
https://discord-giveaways.js.org
MIT License
336 stars 127 forks source link

🐛 Check if embed was edited on end() #462

Closed Nico105 closed 2 years ago

Nico105 commented 2 years ago

Changes

Added private isEnding property which makes sure that ended is only true if the giveaway embed was successfully edited.

The only thing that isn't checked is wheter all win Messages were sent. But checking that would require too much fetching, so it's not worth it. It's most important that the embed is properly edited.

Status

Nico105 commented 2 years ago

Hope this goes well, otherwise revert and thinking of a new approach XD

Nico105 commented 2 years ago

didn't go well => will have reconsider the approach