fix: add "boolean" type to storage

Androz2091 / discord-giveaways

🎉 Complete framework to facilitate the creation of giveaways using discord.js

https://discord-giveaways.js.org

MIT License

336 stars 127 forks source link

fix: add "boolean" type to storage #507

Open needhamgary opened 1 year ago

needhamgary commented 1 year ago

This allows typescript users to write storage: false in the options.

Changes

Status

[ x ] These changes have been tested and formatted properly.
[ ] This PR includes only documentation changes (JSDoc, README or typings), no code change.
[ ] This PR introduces some breaking changes.

Nico105 commented 1 year ago

If I'm not mistaken it's not necessary to set it to false anymore. The code example with that included should be removed. So you can just not use it / leave it undefined, no?

needhamgary commented 1 year ago

When I don't use it, it defaults to "./giveaways.json" and undefined will also fault out in typescript because it's not a string

Nico105 commented 1 year ago

But so are you using a custom db? Because if you are extending the getAllGiveaways function then the "default" shouldn't matter to you.

So I don't really understand what you are trying to achieve/what your logic is.