search

Androz2091 / discord-music-bot

The perfect music bot for your Discord server! 🤘
238 stars 128 forks source link

🐛 Fix cant play some youtube link #76

Closed nitpum closed 2 years ago

nitpum commented 2 years ago

From #24 bot can't play some youtube video And from https://github.com/Androz2091/discord-player/issues/848 we can fix it by passing some ytdlOptions

seikagaku commented 2 years ago

thanks for this fork! managed to fix a similar issue on my own bot by using the added ytdlOptions code, kudos to you man!

krgainer commented 2 years ago

Hmm, I can only maintain stability with the bot when highWaterMark is at 1<<30, as opposed to 25. Other than that, though, this fix is working great.

I made a fork for this change specifically, but if you'd rather update your fork/pull request, I can delete mine :)

nitpum commented 2 years ago

@krgainer I'm not sure about 30, as many people test with 25 (From https://github.com/Androz2091/discord-player/issues/848 and MusicBot ) and it works perfectly.

If 30 work for the most people I will update this, for now I will remain 1 << 25

nitpum commented 2 years ago

@krgainer Updated 1 << 30 :)

krgainer commented 2 years ago

@krgainer Updated 1 << 30 :)

Thanks so much! The stability issues I was having were occurring while hosting the bot on both AWS and GCP (free tiers), though locally didn't seem to have any issues. Thanks for the fix, I'll recend my pull request now!