Androz2091 / discord-player

🎧 Complete framework to simplify the implementation of music commands using discord.js v14
https://discord-player.js.org/
MIT License
589 stars 192 forks source link

fix: do not emit audioTrackRemove event upon jumping to a track #1898

Closed mateie closed 4 months ago

mateie commented 4 months ago

Changes

Added a boolean parameter named emitEvent which defaults to true for <GuildQueuePlayerNode>.jump.

I ran into an issue, where I would like to jump to a track without it emitting the event audioTrackRemove, I think that is a bug If it's not please let me know. This introduces a temporary fix for it. It can be modified to be extendable. It defaults to true, so the code doesn't break in other areas, so it's semi-optional not entirely but I don't know how to word it. It can be also changed from defaulting it to true, it being an optional parameter. It's dependent on how you want it to behave.

Status

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **discord-player-website** | ⬜️ Ignored ([Inspect](https://vercel.com/androz2091s-projects/discord-player-website/3YYGhys1Wjq511mv2RomD3ywPmiY)) | | | Apr 26, 2024 5:35am |