Custom extractors

[jameslinimk]

https://www.npmjs.com/package/xvideos ( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)

[dongsu8142]

LOL I think it's good. But it's gonna be hard.

[dongsu8142]

https://www.npmjs.com/package/get-xvideos

We've fixed a lot of errors and changed the module to the latest one. This is gonna be a lot easier, right?

[twlite]

There was one previously added in dev version: https://npmjs.com/package/xvdl

but we decided to remove xvideos support from this lib. Maybe in the future.

for ref, you can see #286 and 36fa63f

[Androz2091]

Sorry this won't be added. But we could add a way to support "plugins", a simple file that you can require with discord-player

const { registerExtractorPlugin } = require('discord-player');

const extractorPlugin = class Plugin {

    static getData (url) {
        // do something and returns an object
    }

    static validateURL (url) {
        // returns a boolean
    }

    static getStream () {
    }
}

registerExtractorPlugin(extractorPlugin);

something like that could be interesting

[Dragonizedpizza]

its... Concerning... that you would want to add xvideos to a Discord music module...

[twlite]

This feature is done in rewrite

player.use("extractorName", {
    validate: (query) => someBooleanValue,
    getInfo: (query) => {
        // you don't need to validate query here, discord-player handles it for you :)
        // you can return null if you dont have data

        return {
            engine: yourStream,
            // other metadata
        };
    }
});

You can use player.unuse("extractorName") to remove extractor.

Default extractor names

Attachment, Facebook, Reverbnation, Vimeo

after that it should automatically use your extractor when it validates the query passed to player.play. Anything not valid here is treated as youtube search query

[Dragonizedpizza]

This feature is done in rewrite

did you actually add xvideos support..

[twlite]

@Dragonizedpizza no :) but you can add it yourself easily with Discord Player's Extractor API

[Dragonizedpizza]

I don't want to I am happy that you didn't add it