search

Andu2 / FEH-Mass-Simulator

A mass one-on-one dueling simulator for Fire Emblem Heroes.
50 stars 27 forks source link

Decoupling logic and UI #164

Open yangdanny97 opened 6 years ago

yangdanny97 commented 6 years ago

My friend and I are planning out a map solver (ie, calculating what moves to make to beat maps with 0 casualties), and were thinking of using this simulator to calculate battle results.

Since the only way to interact with this is through the UI, we were thinking of helping refactor this to decouple the logic into a separate JS module, with the end goal of calling this logic directly from our solver, written in Python.

We were wondering if there is already a refactoring effort going on that we could join, or if we can start this on a separate branch and merge it in when/if it is completed.

jyc8 commented 6 years ago

Feel free to start a personal branch and merge as you decouple/refactor.

I am currently mostly adding new heroes as they come out and doing small feature update sprints when I have time. Unless conflicts are easily resolved, it is best if you submit pull requests with chunks of changes frequently (or just before new heroes are released) so I can keep up with the modifications.

ajhyndman commented 6 years ago

@yangdanny97 You're welcome to poach ideas or code from this project I launched a while ago:

https://github.com/ajhyndman/fire-emblem-working-title/tree/master/packages/fire-emblem-heroes-calculator

I'm afraid it's pretty out of date, and I'm not very actively maintaining anything anymore.