search

AndunHH / spacemouse

Repository for the space mouse based on four joysticks and keys
Other
42 stars 9 forks source link

Where are the pictures ? #25

Closed coliss86 closed 1 week ago

coliss86 commented 2 weeks ago

Hi,

in https://github.com/AndunHH/spacemouse/commit/b4742517629bafdfebaed9a3dce551f5aa3ecd38, the link to the picture has been updated but this file is not in the repository. Usually, there is a folder pictures/ containing those files. Thus, in the readme.md, the link to those picture is written with ![analog](pictures/file1.jpg).

What do you think ?

AndunHH commented 2 weeks ago

I uploaded the pictures to GitHub just by dragging them into the editor. They are therefore uploaded into a hidden assets folder and named with a hash.

Here on GitHub, I can see the pictures. Can't you?

Or are you talking about the downloaded repo, when viewing and editing the readme offline?

We can go with a distinct pictures folder, the way of uploading via the editor was just more convenient.

coliss86 commented 2 weeks ago

Sure, I can view those pictures but they are not part of the repository. It makes more difficult to see the differences in a PR for example.

coliss86 commented 1 week ago

Perfect ! Thanks :)