search

AndunHH / spacemouse

Repository for the space mouse based on four joysticks and keys
Other
42 stars 9 forks source link

Implemented the encoder wheel for e.g. zooming #31

Closed AndunHH closed 1 week ago

AndunHH commented 1 week ago

This pull request adds the posibility to add an encoder wheel for zooming as described by JoseLuizGZA

Added debug=9 to get values from the simulated zooming.

You need a "regular" encoder and the encoder library by Paul Stoffregen for this to work.

With SIMAXIS = 0, the feature is disabled by default.

AndunHH commented 1 week ago

Is it a "problem" that now everyone needs the encoder library to be installed, even without an encoder in use?

The lib_dependency is included in this PR for platformIO in the platformio.ini and will just ask for the download.

For Arduino IDE users we can avoid the need to load the encoder lib by putting the whole encoderWheel.cpp in #if ROTARY_AXIS >0 Is it worth or an annoying if clause?

coliss86 commented 1 week ago

Is it a "problem" that now everyone needs the encoder library to be installed, even without an encoder in use?

Adding the #if..is a common solution to include or not a lib. When there is no encoder, this library should not be required.

Nice work !