search

Andy-K-Sparklight / Alicorn

A high performance custom Minecraft launcher.
https://alc.pages.dev
GNU General Public License v3.0
43 stars 7 forks source link

Switch from got to fetch #33

Closed Andy-K-Sparklight closed 3 years ago

Andy-K-Sparklight commented 3 years ago

got has offered us amazing api which helped us a lot during development. However, now that Alicorn starts to bring more features, got, though easy to use, sometimes doesn't have the best performance, especially dealing with proxy or agent. (More may because I just created a new agent for each request.)

Considering this, we decided to remove got from Alicorn and use a combination of simple-get, node-keepalive-proxy-agent, etc.

This feature is considered as performance improving, so we shall release it in our next Alicorn Release, that is AppleSauce, I suppose, though we might change it in the last minute ;)

Andy-K-Sparklight commented 3 years ago

At last we decided to use fetch rather than simple-get, and it did work!