search

Andy-set-studio / hylia

Hylia is a lightweight Eleventy starter kit to help you to create your own blog or personal website.
https://hylia.website
MIT License
905 stars 230 forks source link

Why use @tbranyen/jsdom instead of the official package? #128

Open trongthanh opened 4 years ago

trongthanh commented 4 years ago

I'm migrating my current Jekyll blog to 11ty with this nice template.

I noticed that this starter project is using @tbranyen/jsdom package to assist with HTML transforms. However, it seems that this package is just a re-up of the well-known jsdom package from Jest team.

Is there any reason why we're not using the official package instead of this one. I cannot find any derivation notice on the npmjs package page and even the home page link of @tbranyen/jsdom pointing to https://github.com/jsdom/jsdom.

Andy-set-studio commented 4 years ago

It was something to do with custom elements which may have now been resolved.

Glad you’re getting on well with the template!

On Tue, 2 Jun 2020 at 18:30, Thanh Tran notifications@github.com wrote:

I'm migrating my current Jekyll blog to 11ty with this nice template.

I noticed that this starter project is using @tbranyen/jsdom https://www.npmjs.com/package/@tbranyen/jsdom package to assist with HTML transforms. However, it seems that this package is just a re-up of the well-known jsdom https://www.npmjs.com/package/jsdom package from Jest team.

Is there any reason why we're not using the official package instead of this one. I cannot find any derivation notice on the npmjs package page and even the home page link of @tbranyen/jsdom pointing to https://github.com/jsdom/jsdom.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hankchizljaw/hylia/issues/128, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCFKR7QVPL3UCB2GKUKAHDRUUZMXANCNFSM4NQ5SVHA .