Open zplume opened 4 years ago
Hi @hankchizljaw,
I've been testing out the service worker implementation in Hylia and noticed some opportunity for minor improvements, if you're interested:
src/_includes/partials/global/service-worker.js
http://localhost
I've created a service-worker branch in my fork of Hylia with commits that address each of the above bullet points: https://github.com/zplume/hylia/commits/service-worker
Would you be interested in a PR containing the above?
Thanks!
Yes please, that would be great!
Hi @hankchizljaw,
I've been testing out the service worker implementation in Hylia and noticed some opportunity for minor improvements, if you're interested:
src/_includes/partials/global/service-worker.js
is updated.http://localhost
/ ngrok).I've created a service-worker branch in my fork of Hylia with commits that address each of the above bullet points: https://github.com/zplume/hylia/commits/service-worker
Would you be interested in a PR containing the above?
Thanks!