search

Andy-set-studio / hylia

Hylia is a lightweight Eleventy starter kit to help you to create your own blog or personal website.
https://hylia.website
MIT License
905 stars 230 forks source link

Service worker tweaks #134

Open zplume opened 4 years ago

zplume commented 4 years ago

Details / conversation here: https://github.com/hankchizljaw/hylia/issues/133

Thanks!

zplume commented 4 years ago

src\_includes\partials\global\service-worker.js currently excludes any URLs containing .netlify so the Netlify preview build doesn't quite work as expected: pre-caching and the 'offline' page works, but runtime caching doesn't as everything relative to the *.netlify.app domain is excluded.

Not sure if this is intentional (preventing runtime caching on *.netlify.app domains), but commenting out / removing this line should resolve it:

image

Andy-set-studio commented 4 years ago

Thanks for this! I don't have time for a review right now (got a course to release 😉), but I'll add this to my list for next week.