search

Andy-set-studio / hylia

Hylia is a lightweight Eleventy starter kit to help you to create your own blog or personal website.
https://hylia.website
MIT License
905 stars 230 forks source link

add GA support #85

Closed seoh closed 4 years ago

seoh commented 4 years ago

I'm not sure it was in good place, script tag is in footer.njk.

I dont think it is good idea, importing third-party script is in footer template. but I cannot think better place. You will accept this pr or not, supporting GA is necessary for blogging.

Andy-set-studio commented 4 years ago

I wouldn't say it is necessary and I won't be accepting this because GA puts user's privacy at risk. Please also follow the contribution guide next time :)

seoh commented 4 years ago

Totally agree on privacy and risk of GA. I've been finding analytic tools that dont track or fingerprint users like Ackee. By the way, I think it is good for us to add scripts without changing njk template like plugin. I know it is not easy and dont think it can be soon, but might be on milestone or not.

Andy-set-studio commented 4 years ago

Yeh for sure, a bit like the third party comments switch which has logic on the post template.