search

Andy-set-studio / hylia

Hylia is a lightweight Eleventy starter kit to help you to create your own blog or personal website.
https://hylia.website
MIT License
905 stars 230 forks source link

Images are throwing 404 errors #99

Open valzi opened 4 years ago

valzi commented 4 years ago

This may well be my problem rather than hylia's but maybe you can at least tell me which? I'm not very experienced.

Here's the page with images.

https://kowloonplanet.netlify.com/posts/mouse-guard-esque-hex-crawl-with-a-3-year-old/

And here's my repo: https://github.com/valzi/hylia

valzi commented 4 years ago

I figured it out, but I did not figure out how to fix it, quite.

So here's the problem. The CMS generates links that look like ![map](images/hollymap.jpg "map") but it should be putting a / at the beginning. Can we fix that? Seems like a Netlify CMS bug to me, but again, I'm inexperienced.

valzi commented 4 years ago

Solved it! hylia\src\admin\config.yml needs to change public_folder: "images" to public_folder: "/images"

Andy-set-studio commented 4 years ago

Nice work. Fancy putting in a PR?

valzi commented 4 years ago

What is a pr?

On Fri, Feb 7, 2020, 8:56 AM Andy Bell notifications@github.com wrote:

Nice work. Fancy putting in a PR?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/hankchizljaw/hylia/issues/99?email_source=notifications&email_token=ABAWBOBJFDQ7YIH2RBDPPC3RBVZB5A5CNFSM4KRPCHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELDGBBY#issuecomment-583426183, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAWBOHJPCNLKVAGU4HPNYDRBVZB5ANCNFSM4KRPCHAA .

pseigo commented 4 years ago

Looks like this was fixed in https://github.com/hankchizljaw/hylia/pull/104/files, this issue can be closed.