search

AndyButland / UmbracoPersonalisationGroups

Package for personalisation of content with Umbraco.
MIT License
38 stars 18 forks source link

added namespace to route map #23

Closed Lachlann closed 3 years ago

Lachlann commented 3 years ago

Hi Andy.

I have been playing around with v7 of personalisation groups and found an issue with a Controller name clash between this package and our own code (both had a 'MemberController').

This PR fixes the specific issue i had by specifically name-spacing the Route Map for Member Controller. I notice there are other Routes in this config and it might be worth name spacing those too, however i wasn't sure what the best values for those namespaces would be.

Hope this makes sense, happy to discuss.

Cheers Lachlann

AndyButland commented 3 years ago

Thanks for this @Lachlann - looks sensible to me. I'll look to merge in and release an updated version of the package over the weekend,

Lachlann commented 3 years ago

No problem! Cheers

AndyButland commented 3 years ago

Thanks for this @Lachlann. I've updated slightly to apply the same to the other controllers and the V8 version, and pushed out new releases - 1.0.5 for V7 and 2.1.5 for V8 - to our.umbraco.com and NuGet.

Lachlann commented 3 years ago

Thanks Andy

That's great!

Cheers L

On Sun, 13 Dec 2020 at 13:36, Andy Butland notifications@github.com wrote:

Thanks for this @Lachlann https://github.com/Lachlann. I've updated slightly to apply the same to the other controllers and the V8 version, and pushed out new releases - 1.0.5 for V7 and 2.1.5 for V8 - to our.umbraco.com and NuGet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AndyButland/UmbracoPersonalisationGroups/pull/23#issuecomment-744009137, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAHUYAKPIPGSA5HY6QFV4LSUS7PPANCNFSM4UVFPT4Q .

-- Lachlann Rattray -- I make things for the internet.

@codepharaoh https://twitter.com/codepharaoh codepharaoh.co.uk