search

AndyButland / UmbracoPersonalisationGroups

Package for personalisation of content with Umbraco.
MIT License
38 stars 18 forks source link

Check frontendrequest in trackpageview function #43

Closed gregwoodsit closed 1 year ago

gregwoodsit commented 1 year ago

As per issue 25, https://github.com/AndyButland/UmbracoPersonalisationGroups/issues/25, when a macro is rendered in the backoffice an error is thrown as the cookies are trying to be set. Don't believe that backoffice users need to be tracked so have disabled this function.

AndyButland commented 1 year ago

Thanks @gregwoodsit - I saw the issue you had raised but hadn't yet got around to investigating. It's great you have managed to fix it yourself and provide a PR. I'm (again) away for a couple of days, but hopefully come the weekend I'll get chance to review this and put out a new release.

gregwoodsit commented 1 year ago

No worries, let me know if you think it's ok. I didn't look to see if it's applicable to higher versions as yet.

AndyButland commented 1 year ago

Must admit I'm still having trouble replicating the specific error, but the change here makes sense anyway - we shouldn't be tracking when rendering back-office requests. Merging in, and thanks again.

AndyButland commented 1 year ago

You'll find this update in versions 1.0.6 and 2.1.7.