search

AndyLandy / MakeMP3

A tool for creating an MP3 library from a lossless music collection with cue sheets
GNU General Public License v3.0
2 stars 1 forks source link

Improve timestamp-checking feature #14

Open luxagen opened 6 years ago

luxagen commented 6 years ago

MakeMP3 should pay attention to the timestamps of all files relevant to outputting a track, including but not limited to artwork and the source audio file. This could probably be most elegantly done using metaoverride. See commit 60b7fcb0bf4fc425bf04d3e14b942d20ba696987 for the current implementation.

It might be a good idea to rename all keys related to external source files with some kind of common namespace prefix to allow easy iteration. I suggest FILE_ as the convention. Just an idea though. Another alternative would be to define a variable in the templating engine that lists which keys in the cuesheets count as external files.

I believe the correct algorithm would be to compare the existing output file's modstamp with the latest modstamp from all external files related to the track in question.

AndyLandy commented 4 years ago

I am loath to change the REM ARTWORK directive at this point in the proceedings, however it might still be practical to check timestamps on files referenced in both FILE and REM ARTWORK directives. In five years, we have yet to come up with any further source files, so I think this is a low risk prospect.