AndyOGo / stylelint-declaration-strict-value

Specify properties for which a variable, function, keyword or value must be used.
MIT License
133 stars 10 forks source link

Support for stylelint 14 #205

Closed anoopsinghbayes closed 2 years ago

anoopsinghbayes commented 2 years ago

i was looking at migration guide for stylelint 14 and found this

while reading through it i found this image

looks like you would need to add postcss-scss as dependency to do something like this customSyntax: require('postcss-scss'),

AndyOGo commented 2 years ago

Thank you for taking a look into that.

This plugin is using custom matchers for CSS-like syntaxes and does not rely on stylelint for that. Ideally the user configures the syntax he is using without that plugin knowing anything about it.

Anyway the peerDependencies of this plugin describe 14 to be supported. https://github.com/AndyOGo/stylelint-declaration-strict-value/blob/47b6e79889ef85560c7e43678fa6467378d258e3/package.json#L47-L49

AndyOGo commented 2 years ago

@anoopsinghbayes I just double checked.

And I merged a PR #198 for this last November already.

Is there any problem? If so, please provide a failing test or a reproduction repo.

anoopsinghbayes commented 2 years ago

if i dont do this in the stylint config

customSyntax: require('postcss-scss'),

i get the following warning When linting something other than CSS, you should install an appropriate syntax, e.g. "postcss-scss", and use the "customSyntax" option

AndyOGo commented 2 years ago

@anoopsinghbayes Of course you need too install that.

Please double check the migration guidelines for users, these do not apply to plugin authors. https://stylelint.io/migration-guide/to-14#users

All required migrations for plugin authors are addressed in #198 https://stylelint.io/migration-guide/to-14#plugin-authors